Homec4science

Reduce Pholio brokenness for non-image files

Authored by epriestley <git@epriestley.com> on Jun 15 2014, 17:03.

Description

Reduce Pholio brokenness for non-image files

Summary:
Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable:

  • Provide thumbs in the required sizes.
  • Predict the thumb size of these files correctly.
  • Disable inline comments.
  • Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now.

Test Plan: See screenshots.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5359

Differential Revision: https://secure.phabricator.com/D9548

Details

Committed
epriestley <git@epriestley.com>Jun 15 2014, 17:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPH19ed6a1ad60a: Show inline counts on the thumb grid in Pholio
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdcf3b4d32299: Reduce Pholio brokenness for non-image files (authored by epriestley <git@epriestley.com>).Jun 15 2014, 17:03