Homec4science

Don't return any results for viewerprojects() if the viewer is in no projects

Authored by epriestley <git@epriestley.com> on Jan 12 2016, 15:09.

Description

Don't return any results for viewerprojects() if the viewer is in no projects

Summary:
Fixes T10135. When the viewer is a member of no projects, specify the constraint type as a new "EMPTY" type.

When a query has an "EMPTY" constraint, fail fast with no results.

Test Plan:

  • Viewed a viewerprojects() query result set as a user in no projects.
    • Before patch: got a lot of hits. After patch: no hits.
  • Viewed a normal result set, no changes.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10135

Differential Revision: https://secure.phabricator.com/D15003

Details

Committed
epriestley <git@epriestley.com>Jan 12 2016, 16:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPH77ac52c180e6: Update Phabricator documentation of script-and-regex linter for behavioral…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdd21761df9e8: Don't return any results for viewerprojects() if the viewer is in no projects (authored by epriestley <git@epriestley.com>).Jan 12 2016, 16:11