Homec4science

When deleting inline comments, offer "undo" instead of prompting

Authored by epriestley <git@epriestley.com> on Mar 10 2015, 01:27.

Description

When deleting inline comments, offer "undo" instead of prompting

Summary:
Ref T2009. Ref T1460.

Fixes T2618. When users hit "Delete" on inline comments, delete immediately and offer them "Undo". If they delete indirectly (e.g., by clicking "Delete" from the preview at the bottom of the page), we still prompt them, because the "Undo" action either won't be available or may not be easy to find. This is a "refdelete".

Fixes T6464. This was just a mess. Make it not as much of a mess. It should work now. Pretty sure.

Fixes T4999. We did not refresh these links often enough to find targets for them, so they could race with content. Reevaluate them after loading new changes.

Test Plan:

  • Deleted and undid deletion of inlines from main view and preview.
  • Clicked "View" on inlines.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6464, T4999, T2618, T1460, T2009

Differential Revision: https://secure.phabricator.com/D12032

Details

Committed
epriestley <git@epriestley.com>Mar 10 2015, 01:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdaa893e50876: Extend TransactionCommentQuery for Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdd501117e80c: When deleting inline comments, offer "undo" instead of prompting (authored by epriestley <git@epriestley.com>).Mar 10 2015, 01:27