Homec4science

Make AphrontProxyResponse reduce to a real response instead of building a string

Authored by epriestley <git@epriestley.com> on Dec 12 2012, 02:27.

Description

Make AphrontProxyResponse reduce to a real response instead of building a string

Summary: Currently, AphrontProxyResponse is expected to build a string. This prevents some response types (like Dialog) from being proxied, because they have special rules. Instead, make proxy responses reduce into a non-proxied response so it's possible to proxy any type of response and hit all the normal rules for it.

Test Plan: Built a proxied DialogResponse on top of this.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2104, T912

Differential Revision: https://secure.phabricator.com/D4159

Details

Committed
epriestley <git@epriestley.com>Dec 12 2012, 02:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4fe09a0ac71f: Add passthru to AphrontRequest
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdd669c6d4eca: Make AphrontProxyResponse reduce to a real response instead of building a string (authored by epriestley <git@epriestley.com>).Dec 12 2012, 02:27