Homec4science

Make JX.Aphlict a real singleton with a more sensible initialization order

Authored by epriestley <git@epriestley.com> on Jun 24 2014, 00:19.

Description

Make JX.Aphlict a real singleton with a more sensible initialization order

Summary:
Ref T5373. The control flow between aphlict-listener and JX.Aphlict is pretty weird right now, where the listener (which is the highest-level component) has intimate knowledge of how to put the SWF on the page.

Instead:

  • Make JX.Aphlict a real singleton.
  • Instantiate it sooner.
  • Have it handle the flash setup handshake.

Test Plan: Loaded page in debug mode, saw normal flow take place.

Reviewers: joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T5373

Differential Revision: https://secure.phabricator.com/D9699

Details

Committed
epriestley <git@epriestley.com>Jun 24 2014, 00:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPH80f26e96ea40: Install an uncaught exception handler in Aphlict
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdd91732df338: Make JX.Aphlict a real singleton with a more sensible initialization order (authored by epriestley <git@epriestley.com>).Jun 24 2014, 00:19