Abstract and further merge filter menus
dd94512837d7
Actions

Authored by epriestley <git@epriestley.com> on Dec 7 2012, 22:32.

Description

Abstract and further merge filter menus

Summary:

Adds PhabricatorMenuItemView which is a non-hacky object representing a single menu item.
Adds PhabricatorMenuView, a collection of items.
Deletes some busted/old interfaces full of garbage nonsense.
Merges menu item styles from aphront-side-nav-view-css and phabricator-nav-view-css. These are old-style and new-style rules which got partially updated recently.
- The new-style menus have a darker background (#ececec) than the old-style menus (#f7f7f7) so some of the highlight/hover colors weren't visible. I shuffled them around but something or other might need further adjustment.

Test Plan: looked at every menu I could

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T1960

Committed

epriestley <git@epriestley.com>

Dec 7 2012, 22:32

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPHdd94512837d7: Abstract and further merge filter menus (authored by epriestley <git@epriestley.com>).Dec 7 2012, 22:32

				Path
	M			src/__celerity_resource_map__.php
	M			src/__phutil_library_map__.php
	M			src/applications/differential/controller/DifferentialRevisionViewController.php
	M			src/applications/owners/controller/PhabricatorOwnersController.php
	M			src/applications/owners/controller/PhabricatorOwnersDetailController.php
	M			src/applications/owners/controller/PhabricatorOwnersEditController.php
	M			src/applications/owners/controller/PhabricatorOwnersListController.php
	M			src/view/layout/AphrontSideNavFilterView.php
	A			src/view/layout/PhabricatorMenuItemView.php
	A			src/view/layout/PhabricatorMenuView.php
	M			webroot/rsrc/css/aphront/phabricator-nav-view.css
	M			webroot/rsrc/css/aphront/side-nav-view.css
	M			webroot/rsrc/css/layout/phabricator-filetree-view.css
	A			webroot/rsrc/css/layout/phabricator-menu-view.css