Homec4science

Simplify lightboxing and fix a few things

Authored by epriestley <git@epriestley.com> on Oct 24 2012, 02:34.

Description

Simplify lightboxing and fix a few things

Summary:
Minor tweaks to lightboxes.

  • With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it.
  • Make the lightbox go over the menu bar -- was it intentional that it wasn't?
  • Make 'jx-mask' use "position: fixed;" too.
  • Add a loading indicator.
  • In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area.

I'm going to do a couple of other tweaks here but need to update JX.Mask.

Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1896

Differential Revision: https://secure.phabricator.com/D3795

Details

Committed
epriestley <git@epriestley.com>Oct 24 2012, 02:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfdf90b46eb88: Use modern two-stage markup cache (PhabricatorMarkupInterface) in Differential
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHddb1f181c1be: Simplify lightboxing and fix a few things (authored by epriestley <git@epriestley.com>).Oct 24 2012, 02:34