Homec4science

Allow PhabricatorWorker->queueTask() to take full $options

Authored by epriestley <git@epriestley.com> on Oct 5 2015, 18:46.

Description

Allow PhabricatorWorker->queueTask() to take full $options

Summary:
Ref T9252. Currently, queueTask() accepts $priority as its third argument. Allow it to take a full range of $options instead. This API just never got updated after we expanded avialable options.

Arguably this whole API should be some kind of "TaskQueueRequest" object but I'll leave that for another day.

Test Plan:

  • Grepped for queueTask() and verified no other callsites are affected by this API change.
  • Ran some daemons.
  • See also next diff.

Reviewers: hach-que, chad

Reviewed By: hach-que, chad

Maniphest Tasks: T9252

Differential Revision: https://secure.phabricator.com/D14235

Details

Committed
epriestley <git@epriestley.com>Oct 5 2015, 18:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4cf1270ecdd8: In Harbormaster, make sure artifacts are destroyed even if a build is aborted
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHde2bbfef7d14: Allow PhabricatorWorker->queueTask() to take full $options (authored by epriestley <git@epriestley.com>).Oct 5 2015, 18:46