Homec4science

Prevent crash caused by empty array when rendering Pholio mocks

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on Jul 31 2014, 00:10.

Description

Prevent crash caused by empty array when rendering Pholio mocks

Summary: This was causing a crash according to a conversation with @rfergu in IRC. The issue is that if $images_to_show is empty, then $image never gets set, and it attempts to call getID on a null / unset variable.

Test Plan: @rfergu confirmed this fixed the crash.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, rfergu, epriestley

Differential Revision: https://secure.phabricator.com/D10073

Details

Committed
James Rhodes <jrhodes@redpointsoftware.com.au>Jul 31 2014, 00:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8afd8f56f475: update celerity map
Branches
Unknown
Tags
Unknown

Event Timeline

James Rhodes <jrhodes@redpointsoftware.com.au> committed rPHde40cf5ef7d6: Prevent crash caused by empty array when rendering Pholio mocks (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).Jul 31 2014, 00:10