Homec4science

Revision substate CLOSED_FROM_ACCEPTED

Authored by Aviv Eyal <avivey@gmail.com> on Jun 27 2016, 22:29.

Description

Revision substate CLOSED_FROM_ACCEPTED

Summary:
Ref T9838.

Add a Properties field to Revision, and update a wasAcceptedBeforeClose when closing a revision.

Test Plan:
A quick run through the obvious steps (Close with commit/manually, with or w/o accept) and calling differential.query shows the wasAcceptedBeforeClose property was setup correctly.

Pushing closed + accepted passes the relevant herald, which was my immediate issue; Pushing un-accepted is blocked.
Test the "commit" rule (Different from "pre-commit") by hacking the DB and running the "has accepted revision" rule in a test-console.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T9838

Differential Revision: https://secure.phabricator.com/D15085

Details

Committed
avivey <autocommitter@example.com>Jun 27 2016, 22:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe984f0eb76fe: Update quickstart.sql
Branches
Unknown
Tags
Unknown

Event Timeline

avivey <autocommitter@example.com> committed rPHde6349dd67af: Revision substate CLOSED_FROM_ACCEPTED (authored by Aviv Eyal <avivey@gmail.com>).Jun 27 2016, 22:29