Homec4science

Send mail to audit comment author too

Authored by Ben Alpert <spicyjalapeno@gmail.com> on Mar 31 2014, 16:52.

Description

Send mail to audit comment author too

Summary: Previously, you would not receive a mail message for the first comment you make on an audit, but you would for subsequent comments because everyone who's made a comment would be CCed on the email. This mirrors DifferentialTransactionEditor's getMailTo which always adds $object->getAuthorPHID().

Test Plan: With self mail turned on, made the first comment on a commit and received an email for it. With self mail turned off, commented on a different commit and saw in bin/mail list-outbound that the message was voided.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8650

Details

Committed
epriestley <git@epriestley.com>Mar 31 2014, 16:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf239d81c1cf8: Allow very long notes on flags
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdeba531401f7: Send mail to audit comment author too (authored by Ben Alpert <spicyjalapeno@gmail.com>).Mar 31 2014, 16:52