Homec4science

Convert to custom encoding for diffusion blame views

Authored by David Reuss <david@upsys.dk> on Aug 12 2012, 17:50.

Description

Convert to custom encoding for diffusion blame views

Summary:
If a repository is configured with a custom encoding, it wasn't respected by DiffusionGitFileContentQuery making all views with
non-UTF8 characters fail. Check if we have a custom encoding and encode if any it set.

NOTE: This only works for Git repositories.

Test Plan: Browsed a repository with custom encoding before and after this patch.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T452

Differential Revision: https://secure.phabricator.com/D3251

Details

Committed
epriestley <git@epriestley.com>Aug 12 2012, 17:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3e29921f5e32: Use phutil_utf8_convert() in Phabricator
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdf3162584eb7: Convert to custom encoding for diffusion blame views (authored by David Reuss <david@upsys.dk>).Aug 12 2012, 17:50