Homec4science

Always run "behavior-populate" before "behavior-show-more"

Authored by epriestley <git@epriestley.com> on Mar 5 2015, 23:02.

Description

Always run "behavior-populate" before "behavior-show-more"

Summary:
Ref T2009. This clears the stage for D11977.

Specifically, D11977 moves "show context" logic into ChangesetViewManager, but those objects won't exist if we don't run "behavior-populate" first.

Generally, this increases consistency across changeset views -- which is still very low overall, but getting slightly better.

Both of these should probably move up more and use ChangesetListView, but we don't need to do that quite yet.

Test Plan:

  • Took changeset actions in Phriction diff view.
  • Took changeset actions in Differential standalone view.
  • Took changeset actions in normal Differential view.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D11978

Details

Committed
epriestley <git@epriestley.com>Mar 5 2015, 23:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPH06df75ebbd4f: Render "Show Context" blocks in unified view
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdf661eca355b: Always run "behavior-populate" before "behavior-show-more" (authored by epriestley <git@epriestley.com>).Mar 5 2015, 23:02