Homec4science

Fix two issues with embedding other fields inside "Summary" or "Test Plan" in…

Authored by epriestley <git@epriestley.com> on Jan 25 2017, 20:23.

Description

Fix two issues with embedding other fields inside "Summary" or "Test Plan" in Differential with the web UI

Summary:
Ref T11114. Converting to EditEngine caused us to stop running this validation, since these fields no longer subclass this parent. Restore the validation.

Also, make sure we check the first line of the value, too. After the change to make "Tests: xyz" a valid title, you could write silly summaries / test plans and escape the check if the first line was bogus.

Test Plan: {F2493228}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17248

Details

Committed
epriestley <git@epriestley.com>Jan 25 2017, 22:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPHce09ab9b0e1a: Use new menu contsants in home menu item
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdf939f1337fd: Fix two issues with embedding other fields inside "Summary" or "Test Plan" in… (authored by epriestley <git@epriestley.com>).Jan 25 2017, 22:07