Homec4science

Prevent "Maniphest Tasks" field from creating empty comment when revisions are…

Authored by epriestley <git@epriestley.com> on Dec 16 2011, 22:26.

Description

Prevent "Maniphest Tasks" field from creating empty comment when revisions are updated

Summary:

  • If you update a revision with a nonempty "Maniphest Tasks" field, an empty

comment is posted (see T586).

  • The transaction email currently says "Attached revision 'Unknown

Differential Revision'", move attaching to "didWriteRevision()" to make sure the
object has been written.

Test Plan: - Attached; updated a revision.

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Maniphest Tasks: T685

Differential Revision: 1223

Details

Committed
epriestley <git@epriestley.com>Dec 16 2011, 22:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3cd92ab075c1: Minor fix to D1186 to enforce ordering.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdfc3506240eb: Prevent "Maniphest Tasks" field from creating empty comment when revisions are… (authored by epriestley <git@epriestley.com>).Dec 16 2011, 22:32