Homec4science

Fix window-exiting drags and drag-and-hold behaviors in JX.Scrollbar

Authored by epriestley <git@epriestley.com> on Jan 25 2015, 01:42.

Description

Fix window-exiting drags and drag-and-hold behaviors in JX.Scrollbar

Summary:
Fixes two issues:

  • In Firefox, dragging outside the window and releasing the mouse button would miss the mouseup event. This would leave the bar dragging, even though the user had released the mouse button.
  • In all browsers, dragging the handle and then holding your cursor in one place for more than a second would hide the handle. Instead, never hide the handle during a drag.

Test Plan:

  • In Firefox, dragged handle right (outside of window) and released mouse button. Waved cursor over window; no more "sticky" scroll.
  • In FF/Chrome/Safari, dragged handle and held cursor in same position for several seconds. No more handle hide.
  • Waved cursor over window and made sure normal hiding still works.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11487

Details

Committed
epriestley <git@epriestley.com>Jan 25 2015, 01:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6288d8a7d4b5: Support scrollbar snapback on Windows
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe0289070db8f: Fix window-exiting drags and drag-and-hold behaviors in JX.Scrollbar (authored by epriestley <git@epriestley.com>).Jan 25 2015, 01:42