Homec4science

Added some additional assertion methods.

Authored by Joshua Spence <josh@joshuaspence.com> on Mar 9 2014, 04:11.

Description

Added some additional assertion methods.

Summary:
There are quite a few tests in Arcanist, libphutil and Phabricator that do something similar to $this->assertEqual(false, ...) or $this->assertEqual(true, ...).

This is unnecessarily verbose and it would be cleaner if we had assertFalse and assertTrue methods.

Test Plan: I contemplated adding a unit test for the getCallerInfo method but wasn't sure if it was required / where it should live.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8460

Details

Committed
epriestley <git@epriestley.com>Mar 9 2014, 04:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPH08040ae984ad: Fix action links in documentview
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe11adc4ad76c: Added some additional assertion methods. (authored by Joshua Spence <josh@joshuaspence.com>).Mar 9 2014, 04:16