Homec4science

Make auth provider autologin modular and implement it for all OAuth2 adapters

Authored by epriestley <git@epriestley.com> on Jun 6 2016, 22:04.

Description

Make auth provider autologin modular and implement it for all OAuth2 adapters

Summary:
Ref T10785. Around the time we launched Phacility SAAS we implemented this weird autologin hack. It works fine, so clean it up, get rid of the instanceof stuff, and support it for any OAuth2 provider.

(We could conceivably support OAuth1 as well, but no one has expressed an interest in it and I don't think I have any OAuth1 providers configured correctly locally so it would take a little bit to set up and test.)

Test Plan:

  • Configured OAuth2 adapters (Facebook) for auto-login.
  • Saw no config option on other adapters (LDAP).
  • Nuked all options but one, did autologin with Facebook and Phabricator.
  • Logged out, got logout screen.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10785

Differential Revision: https://secure.phabricator.com/D16060

Details

Committed
epriestley <git@epriestley.com>Jun 6 2016, 23:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH511f703657f2: Tidy up quick create menu spacing
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe1a9473eda04: Make auth provider autologin modular and implement it for all OAuth2 adapters (authored by epriestley <git@epriestley.com>).Jun 6 2016, 23:33