Homec4science

Give organizers in ICS exports a dummy email address to placate Gmail

Authored by epriestley <git@epriestley.com> on Oct 30 2016, 17:09.

Description

Give organizers in ICS exports a dummy email address to placate Gmail

Summary:
Ref T10747. In the in-email ICS event card that Gmail shows, it has a "Who" field which reads "Unknown Organizer*" if the URI for the organizer isn't email-address-like.

Previously, we used a URI like https://phabricator.install.com/p/username, which I think is OK as far as RFC 5545 is concerned, but Gmail doesn't like it.

Instead, use PHID-USER-asdfa@phabricator.install.com, which doesn't go anywhere, but makes Gmail happy. Users don't normally see this URI anyway.

Test Plan:
Got a readable "Who" in Gmail when importing an event exported from Calendar:

{F1890571}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16772

Details

Committed
epriestley <git@epriestley.com>Oct 30 2016, 17:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd9c91f857cef: Apply a TYPE_CREATE transaction when importing events to improve strings in…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe1a9b7694517: Give organizers in ICS exports a dummy email address to placate Gmail (authored by epriestley <git@epriestley.com>).Oct 30 2016, 17:20