Homec4science

Minor Tasks fixes

Authored by epriestley <git@epriestley.com> on Mar 22 2012, 21:55.

Description

Minor Tasks fixes

Summary:

  • We need to sort Projects explicitly because we go through task-by-task which ruins the ordering. My test case was just small enough not to notice.
  • Push "No Project" to the bottom explicitly.
  • Simplify/fix the pull of "Unassigned" to the top.
  • Fix a return type.

Test Plan: Tested the various sorting cases against a larger test data set.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1988

Details

Committed
epriestley <git@epriestley.com>Mar 22 2012, 21:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc92e37c1b1b1: Minor, pass $request to OAuthLogin controller. See https://secure.phabricator.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe2a457873e5d: Minor Tasks fixes (authored by epriestley <git@epriestley.com>).Mar 22 2012, 21:55