make applicationTransactionsCommentView have a "Login to comment." button if…
e3181fcbe730
Actions

Authored by Bob Trahan <bob.trahan@gmail.com> on Mar 7 2013, 22:02.

Description

make applicationTransactionsCommentView have a "Login to comment." button if user is not logged in

Summary: okay title. other apps can get this by implementing shouldAllowPublic and set(ting)RequestURI on TransactionsCommentView. note i put some css inline -- let me know if that belongs someplace else or needs better design.

Test Plan: viewed a mock logged out and saw new button. used new button and ended up on the mock logged in with a clean URI.

Reviewers: epriestley, chad

Reviewed By: chad

CC: aran, Korvin

Maniphest Tasks: T2653

Differential Revision: https://secure.phabricator.com/D5266

Details

Committed

Bob Trahan <bob.trahan@gmail.com>

Mar 7 2013, 22:02

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHe6c73a839687: fixing unloaded object handles for project member changes in feed view

Branches

Unknown

Tags

Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHe3181fcbe730: make applicationTransactionsCommentView have a "Login to comment." button if… (authored by Bob Trahan <bob.trahan@gmail.com>).Mar 7 2013, 22:02

Changes (6)

				Path
	M			src/applications/auth/controller/PhabricatorLoginController.php
	M			src/applications/pholio/controller/PholioMockViewController.php
	M			src/applications/pholio/view/PholioMockImagesView.php
	M			src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
	M			webroot/rsrc/css/aphront/form-view.css
	M			webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js