Homec4science

Correctly focus elements in Workflow dialogs

Authored by epriestley <git@epriestley.com> on May 10 2011, 20:24.

Description

Correctly focus elements in Workflow dialogs

Summary:
JX.Workflow does a JX.DOM.find() for the sigil default, but fails because we
render with phutil_render_tag() instead of javelin_render_tag() so sigils are
not converted correctly.

Test Plan:
Opened an inline comment in differential, got focus on the <textarea />

Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen
CC: aran, tuomaspelkonen, epriestley
Differential Revision: 259

Details

Committed
epriestley <git@epriestley.com>May 10 2011, 20:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd5dfa5faf5c8: Never hide file contents if they have comments.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe32fd1a871c3: Correctly focus elements in Workflow dialogs (authored by epriestley <git@epriestley.com>).May 10 2011, 20:28