Homec4science

Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal

Authored by epriestley <git@epriestley.com> on Jul 10 2014, 19:18.

Description

Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal

Summary:
Fixes T3732. Ref T1205. Ref T3116.

External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects.

Currently, we have a very restrictive CAN_VIEW policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion.

However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar).

Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach:

  • Add CAN_EDIT on these objects.
  • Make that very restricted, but open up CAN_VIEW.
  • Require CAN_EDIT any time we're going to do something authentication/identity related.

This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net.

I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere.

Test Plan:

  • Viewed external accounts.
  • Linked an external account.
  • Refreshed an external account.
  • Edited profile picture.
  • Viewed sessions panel.
  • Published a bunch of stuff to Asana/JIRA.
  • Legalpad signature page now shows external accounts.

{F171595}

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T3732, T1205, T3116

Differential Revision: https://secure.phabricator.com/D9767

Details

Committed
epriestley <git@epriestley.com>Jul 10 2014, 19:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH02c3200867b1: Respond more gracefully when a git push deletes a nonexistent ref
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe46826ad364d: Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal (authored by epriestley <git@epriestley.com>).Jul 10 2014, 19:18