Homec4science

Migrate the "badcommit" table to use the less-hacky "hint" mechanism

Authored by epriestley <git@epriestley.com> on Aug 24 2016, 14:24.

Description

Migrate the "badcommit" table to use the less-hacky "hint" mechanism

Summary: Ref T11522. This migrates any "badcommit" data (which probably only exists at Facebook and on 1-2 other installs in the wild) to the new "hint" table.

Test Plan:

  • Wrote some bad commit annotations to the badcommit table.
  • Viewed them in the web UI and used bin/repository reparse --change ... to reparse them. Saw "this is bad" messages.
  • Ran migration, verified that valid "badcommit" rows were successfully migrated to become "hint" rows.
  • Viewed the new web UI and re-parsed the change, saw "unreadable commit" messages.
  • Viewed a good commit; reparsed a good commit.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11522

Differential Revision: https://secure.phabricator.com/D16435

Details

Committed
epriestley <git@epriestley.com>Aug 24 2016, 18:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8a4fbcd8c015: Provide a new "hint" table for weird commits (rewritten, unreadable)
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe4c4724afd6b: Migrate the "badcommit" table to use the less-hacky "hint" mechanism (authored by epriestley <git@epriestley.com>).Aug 24 2016, 18:32