Homec4science

Fix issues where Drydock queries didn't work correctly with empty arrays

Authored by June Rhodes <jrhodes@redpointsoftware.com.au> on Aug 24 2015, 13:23.

Description

Fix issues where Drydock queries didn't work correctly with empty arrays

Summary: Ref T2015. This fixes issues where the Drydock queries wouldn't filter (or throw an exception) when passed empty arrays for their with methods. In addition, this also adds array_unique to the resource and lease subqueries so that we don't pull in a bunch of stuff if logs or leases have the same related objects.

Test Plan: Tested it by using DarkConsole on the log controller.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: joshuaspence, Korvin, epriestley

Maniphest Tasks: T2015

Differential Revision: https://secure.phabricator.com/D10879

Details

Committed
June Rhodes <jrhodes@redpointsoftware.com.au>Aug 24 2015, 13:23
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0d4f9363a0f2: Improve Drydock log search engine
Branches
Unknown
Tags
Unknown

Event Timeline

June Rhodes <jrhodes@redpointsoftware.com.au> committed rPHe55a197dd683: Fix issues where Drydock queries didn't work correctly with empty arrays (authored by June Rhodes <jrhodes@redpointsoftware.com.au>).Aug 24 2015, 13:23