Homec4science

Load blame in Diffusion by AJAX

Authored by vrana <jakubv@fb.com> on Mar 5 2013, 23:31.

Description

Load blame in Diffusion by AJAX

Summary:
I have blame enabled by default and displaying files with long history takes easily over 10 seconds.
Load the blame data by AJAX instead.
This is actually doing more work and the total response time is longer but it's worth it for me as I am interested just in the file contents quite often.

I know you were talking about building blame cache but until we have it...

I'm not sure if the AJAX loading indicator in bottom right corner is enough to inform the user that we are loading it on background.

Test Plan:
?view=highlighted
?view=plainblame
?view=blame

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5244

Details

Committed
vrana <jakubv@fb.com>Mar 6 2013, 16:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb0e58fadfd33: Re-run celerity mapper
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHe57f20905683: Load blame in Diffusion by AJAX (authored by vrana <jakubv@fb.com>).Mar 6 2013, 16:44