Homec4science

Retroactively populate Phriction mailKey column

Authored by epriestley <git@epriestley.com> on Nov 7 2014, 18:48.

Description

Retroactively populate Phriction mailKey column

Summary:
Fixes T6487. Ref T1191. Ref T4029. D10756 introduced, but did not populate, this column. This can cause it to fill with "\0\0\0..." after adjustment.

Regardless of the adjustment issue, it's nice to populate this column anyway because there's no fundamental reason an object can't have mail sent about it without being saved first, even though it may not practically be possible in the codebase today.

Test Plan:

  • Ran storage upgrade, saw the column populate for older documents.
  • Forced a couple of keys to bad values (too short or with "\0") and saw the migration fix them.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4029, T1191, T6487

Differential Revision: https://secure.phabricator.com/D10804

Details

Committed
epriestley <git@epriestley.com>Nov 7 2014, 18:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPH677e161865a4: Phriction - fix bug with delete
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe58259b4f52b: Retroactively populate Phriction mailKey column (authored by epriestley <git@epriestley.com>).Nov 7 2014, 18:48