Homec4science

Improve error and exception handling for Drydock resources

Authored by epriestley <git@epriestley.com> on Oct 1 2015, 17:12.

Description

Improve error and exception handling for Drydock resources

Summary:
Ref T9252. Currently, error handling behavior isn't great and a lot of errors aren't dealt with properly. Try to improve this by making default behaviors better:

  • Yields, slot lock exceptions, and aggregate or proxy exceptions containing an excpetion of these types turn into yields.
  • All other exceptions are considered permanent failures. They break the resource and

This feels a little bit "magical" but I want to try to get the default behaviors to align reasonably well with expectations so that blueprints mostly don't need to have a ton of error handling. This will probably need at least some refinement down the road, but it's a reasonable rule for all exception/error conditions we currently have.

Test Plan: I did a clean build, but haven't vetted this super thoroughly. Next diff will do the same thing to leases, then I'll work on stabilizing this code better.

Reviewers: chad, hach-que

Reviewed By: hach-que

Maniphest Tasks: T9252

Differential Revision: https://secure.phabricator.com/D14211

Details

Committed
epriestley <git@epriestley.com>Oct 1 2015, 17:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6b775e609053: Add more Drydock log types and some additional logging
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe589d152310a: Improve error and exception handling for Drydock resources (authored by epriestley <git@epriestley.com>).Oct 1 2015, 17:12