Homec4science

Apply phutil_utf8ize() to stderr output from VCS commands prior to logging

Authored by epriestley <git@epriestley.com> on Jan 31 2016, 01:03.

Description

Apply phutil_utf8ize() to stderr output from VCS commands prior to logging

Summary: Ref T10228. Commands like git-http-backend can emit errors with raw bytes in the output. Sanitize these if present so we can log them in JSON format.

Test Plan: Edited this into production. >_> sneaky sneaky <_<

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10228

Differential Revision: https://secure.phabricator.com/D15144

Details

Committed
epriestley <git@epriestley.com>Jan 31 2016, 01:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPH41262150dfb5: Remove unused call to phui-text
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe5947e08d389: Apply phutil_utf8ize() to stderr output from VCS commands prior to logging (authored by epriestley <git@epriestley.com>).Jan 31 2016, 01:46