Homec4science

Reduce the amount of OAuth1/OAuth2 code duplication for rendering login buttons

Authored by epriestley <git@epriestley.com> on Sep 3 2013, 19:30.

Description

Reduce the amount of OAuth1/OAuth2 code duplication for rendering login buttons

Summary: Ref T3687. These buttons don't work quite the same way, but are similar enough that the code seems worth consolidating.

Test Plan: Viewed and clicked both OAuth1 (Twitter, JIRA) and OAuth2 (Facebook) login buttons. Got logins.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3687

Differential Revision: https://secure.phabricator.com/D6874

Details

Committed
epriestley <git@epriestley.com>Sep 3 2013, 19:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH25eb401e18ae: Handle user aborts during auth workflows in Phabricator
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe5b4ce5525d7: Reduce the amount of OAuth1/OAuth2 code duplication for rendering login buttons (authored by epriestley <git@epriestley.com>).Sep 3 2013, 19:30