Homec4science

In Audit list and Owners list, show overall commit audit status instead of semi…

Authored by epriestley <git@epriestley.com> on Jan 12 2017, 21:56.

Description

In Audit list and Owners list, show overall commit audit status instead of semi-viewer status

Summary:
Fixes T9482. Historically, Audit was somewhat confused about whether queries and views should act on the viewer's status or the object's status.

This realigns Audit to work like Differential: we show overall status for the commit, just like we show overall status for revisions. This better aligns with expectation and isn't weird/confusing, and bucketing should handle all the "what do I need to do" stuff now (or, at least, seems to have in Differential).

This is also how every other type of object works in every other application, AFAIK (all of them show object status, not viewer's-relationship-to-the-object status).

Test Plan:

  • Viewed commit lists in Owners and Audit.
  • Saw commit overall statuses, not my personal status.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9482

Differential Revision: https://secure.phabricator.com/D17195

Details

Committed
epriestley <git@epriestley.com>Jan 12 2017, 22:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPH19525ed81afa: Add diffusion.commit.search Conduit API method
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe66a03eaa3e4: In Audit list and Owners list, show overall commit audit status instead of semi… (authored by epriestley <git@epriestley.com>).Jan 12 2017, 22:41