Homec4science

Remove "mysql.configuration-provider" configuration option

Authored by epriestley <git@epriestley.com> on Nov 22 2016, 13:23.

Description

Remove "mysql.configuration-provider" configuration option

Summary:
Ref T11044. This was old Facebook cruft for reading configuration from SMC (and maybe doing some other questionable things). See D183.

(See also D175 for discussion of this from 2011.)

In modern Phabricator, you can subclass SiteConfig to provide dynamic configuration, and we do so in the Phacility cluster. This lets you change any config, and change in response to requests (e.g., for instancing) and is generally more powerful than this mechanism was.

This configuration provider theoretically let you roll your own replication or partitioning, but in practice I believe no one ever did, and no one ever could have anyway without more support in the upstream (for migrations, read-after-write, etc).

Test Plan:

  • Grepped for removed option.
  • Browsed around with clustering off.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11044

Differential Revision: https://secure.phabricator.com/D16911

Details

Committed
epriestley <git@epriestley.com>Nov 22 2016, 18:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4da74166fe87: When storage is partitioned, refuse to serve requests unless web and databases…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe6bfa1bd2388: Remove "mysql.configuration-provider" configuration option (authored by epriestley <git@epriestley.com>).Nov 22 2016, 18:24