Homec4science

Don't escape quotation marks when printing the monospaced CSS rule

Authored by epriestley <git@epriestley.com> on Apr 22 2015, 18:28.

Description

Don't escape quotation marks when printing the monospaced CSS rule

Summary:
Fixes T7888. This is currently safe, but double quotes are incorrectly escaped.

To keep them unescaped, we have to punch through PhutilSafeHTML a bit. Since the allowable characters are strictly filtered this is still safe in practice, just not as theoretically-safe.

Test Plan: Set font to 32px "impact" (with quotes), saw impact font.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7888

Differential Revision: https://secure.phabricator.com/D12506

Details

Committed
epriestley <git@epriestley.com>Apr 22 2015, 18:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4dea152215cc: Fix a possible undefined variable
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe7702acdc659: Don't escape quotation marks when printing the monospaced CSS rule (authored by epriestley <git@epriestley.com>).Apr 22 2015, 18:28