Homec4science

Don't reverse downloaded raw diff

Authored by vrana <jakubv@fb.com> on Aug 18 2012, 11:15.

Description

Don't reverse downloaded raw diff

Summary:
The logic here was swapped - new file should be on the right side.
Plus we had a fatal for VS = -1 where new file should be on left.

Test Plan:
Downloaded raw diff of:

  • base VS change
  • change VS change
  • change VS change with unmodified file

Reviewers: epriestley, btrahan

Reviewed By: btrahan

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3333

Details

Committed
vrana <jakubv@fb.com>Aug 20 2012, 21:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH801a17627404: Link Phabricator from footer
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHe7796caa788c: Don't reverse downloaded raw diff (authored by vrana <jakubv@fb.com>).Aug 20 2012, 21:21