Homec4science

Fix commit parsing in owners tool after bug introduced in…

Authored by Dave Ingram <dmi@teamgroupspaces.com> on Mar 21 2012, 16:02.

Description

Fix commit parsing in owners tool after bug introduced in 30ae22bfcff71fa3f14e38fd3cd597448df501c3

Summary:
A bug was introduced in
rP30ae22bfcff71fa3f14e38fd3cd597448df501c3 which caused commits to start
being parsed as if the repository callsign was empty. This caused errors
and problems and much unhappiness. Example error:

EXCEPTION: (Exception) No such repository ''. at [.../phabricator/src/applications/diffusion/request/base/DiffusionRequest.php:130]

Test Plan: Saw that commit parsing was breaking. Applied fix. Saw that commits parsed again.

Reviewers: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1974

Details

Committed
Dave Ingram <dmi@teamgroupspaces.com>Mar 21 2012, 16:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH81be1cf27b5a: Fix batch editor for edits which both add and remove projects
Branches
Unknown
Tags
Unknown

Event Timeline

Dave Ingram <dmi@teamgroupspaces.com> committed rPHe77f77619831: Fix commit parsing in owners tool after bug introduced in… (authored by Dave Ingram <dmi@teamgroupspaces.com>).Mar 21 2012, 16:10