Homec4science

Make differential revision ID parsing more robust

Authored by Nick Harper <nharper@fb.com> on Dec 13 2012, 02:43.

Description

Make differential revision ID parsing more robust

Summary:
If something that doesn't belong to any field appears in the commit message
below the differential revision field, it gets included as part of the
value for the field, which can mess up parsing.

Test Plan:
called differential.parsecommitmessage on a commit whose differential
revision field wasn't being parsed earlier (it had a line of dashes two
lines below the Differential Revision: line).

Reviewers: epriestley, vrana

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4171

Details

Committed
Nick Harper <nharper@fb.com>Dec 13 2012, 05:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcce5ebebe98b: Improve Drydock's ability to allocate leases correctly
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPHe7bcdcdb9458: Make differential revision ID parsing more robust (authored by Nick Harper <nharper@fb.com>).Dec 13 2012, 05:01