Homec4science

Fix an issue where we would try to release an unheld lock

Authored by epriestley <git@epriestley.com> on Apr 2 2015, 02:37.

Description

Fix an issue where we would try to release an unheld lock

Summary: Fixes T7484. If the lock failed, we'd still try to unlock it, which is incorrect.

Test Plan: Ran two bin/repository update X in different windows, got proper LockException instead of indirect symptomatic "not locked by this process" exception.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7484

Differential Revision: https://secure.phabricator.com/D12253

Details

Committed
epriestley <git@epriestley.com>Apr 2 2015, 02:37
Pushed
aubortJan 31 2017, 17:16
Parents
rPH898ccd7552db: Add translation for the string "Submit" for the Very Wow translation
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe9886c4353df: Fix an issue where we would try to release an unheld lock (authored by epriestley <git@epriestley.com>).Apr 2 2015, 02:37