Homec4science

Allow inline comments to be individually hidden

Authored by epriestley <git@epriestley.com> on May 27 2015, 19:28.

Description

Allow inline comments to be individually hidden

Summary:
Ref T7447. Implements per-viewer comment hiding. Once a comment is obsolete or uninteresting, you can hide it completely.

This is sticky per-user.

My hope is that this will strike a better balance between concerns than some of the other approaches (conservative porting, summarization, hide-all).

Specifically, this adds a new action here:

{F435621}

Clicking it completely collapses the comment into a small icon on the previous line, and saves the comment state as hidden for you:

{F435626}

You can click the icon to reveal all hidden comments below the line.

Test Plan:

  • Hid comments.
  • Showed comments.
  • Created, edited, deleted and submitted comments.
  • Used Diffusion comments (hiding is not implemented there yet, but I'd plan to bring it there eventually if it works out in Differential).

Reviewers: btrahan, chad

Reviewed By: btrahan

Subscribers: jparise, yelirekim, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D13009

Details

Committed
epriestley <git@epriestley.com>May 27 2015, 19:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfcac85d80733: Allow configuration of a "staging area" for each repository
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe9f4a84a892c: Allow inline comments to be individually hidden (authored by epriestley <git@epriestley.com>).May 27 2015, 19:28