Homec4science

Optimize matching regexps in Herald rules

Authored by vrana <jakubv@fb.com> on Aug 15 2012, 00:03.

Description

Optimize matching regexps in Herald rules

Summary:
We spend 6.37 s in this condition on a big diff.
By adding the 'S' flag, the time is down to 2.15 s.

Test Plan: DifferentialRevisionEditor::newRevisionFromConduitWithDiff()

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3284

Details

Committed
vrana <jakubv@fb.com>Aug 15 2012, 00:14
Pushed
aubortJan 31 2017, 17:16
Parents
rPH012370c6ab12: Use sprites for (nearly) all application icons
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHea0fe6d64b36: Optimize matching regexps in Herald rules (authored by vrana <jakubv@fb.com>).Aug 15 2012, 00:14