Homec4science

Fix issue where "{Fnnn, size}" renders as though "size=full"

Authored by epriestley <git@epriestley.com> on Jan 2 2013, 23:03.

Description

Fix issue where "{Fnnn, size}" renders as though "size=full"

Summary: We interpret "size" as "size => true", and "true == 'full'", so we hit the wrong branch in the switch(). String cast explicitly.

Test Plan: Typed {Fnnn, size}; saw it render as a thumb instead of full.

Reviewers: btrahan, codeblock

Reviewed By: codeblock

CC: frozendevil, aran

Differential Revision: https://secure.phabricator.com/D4323

Details

Committed
epriestley <git@epriestley.com>Jan 2 2013, 23:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa3fdb20a8ea9: Move GC into PHP and simplify it
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHea52c30bca10: Fix issue where "{Fnnn, size}" renders as though "size=full" (authored by epriestley <git@epriestley.com>).Jan 2 2013, 23:03