Homec4science

Replace ActionHeader minicons with Font icons

Authored by epriestley <git@epriestley.com> on Aug 15 2014, 20:08.

Description

Replace ActionHeader minicons with Font icons

Summary:
Ref T5885. See D10276.

Currently, ActionHeaders can only have minicons, and we don't use them anywhere and they probably don't make much sense in the product anymore.

Instead, allow them to have font icons. Remove minicons, which have no callsites and probably won't in the future.

Test Plan:
{F190925}

  • Grepped for minicons.
  • Grepped for setHeaderIcon().

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5885

Differential Revision: https://secure.phabricator.com/D10277

Details

Committed
epriestley <git@epriestley.com>Aug 15 2014, 20:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf9de495d0bc3: Use `file.download` to retrieve macro images in the IRC macro bot
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHeaacb4a5113c: Replace ActionHeader minicons with Font icons (authored by epriestley <git@epriestley.com>).Aug 15 2014, 20:08