Homec4science

Begin improving the soundness of received mail

Authored by epriestley <git@epriestley.com> on May 14 2013, 01:32.

Description

Begin improving the soundness of received mail

Summary:
We/I broke a couple of things here recently (see D5911) and are doing some work here in general (see D5912, etc.).

Generally, this code is pretty oldschool and not especially well architected for modern application-oriented Phabricator. It hardcodes a lot of stuff which should be applications' responsibilites.

Take the first steps toward making it more solid to reduce the risk here. In particular:

  • Factor out the "self mail" and "duplicate mail" checks and add unit tests.
  • Make Message-ID hash handling automatic.

Test Plan: Ran unit tests.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5915

Details

Committed
epriestley <git@epriestley.com>May 14 2013, 01:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH99f648e4ebf2: Don't show empty attributes.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHeabe3a4d3314: Begin improving the soundness of received mail (authored by epriestley <git@epriestley.com>).May 14 2013, 01:32