Homec4science

Construct diffs with attached changesets, even if empty

Authored by epriestley <git@epriestley.com> on Jul 1 2013, 18:02.

Description

Construct diffs with attached changesets, even if empty

Summary: See discussion in IRC. Not 100% sure what's going on here because of email ghost theives, but conceivably a commit with no changes will end up with null changesets instead of array() changesets, which throws. Such diffs are certianly possible (git commit --allow-empty) even if they aren't the issue in this specific case. See T3416. Initialize changesets to array() to avoid throwing.

Test Plan:
Viewed some commits?

iiam

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D6339

Details

Committed
epriestley <git@epriestley.com>Jul 1 2013, 18:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfde37a18cfb7: Allow filtering maniphest tasks authored by agents
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHeb49d8a52b16: Construct diffs with attached changesets, even if empty (authored by epriestley <git@epriestley.com>).Jul 1 2013, 18:02