Homec4science

Fix an issue with URIs missing trailing slashes, like "/maniphest"

Authored by epriestley <git@epriestley.com> on Aug 6 2012, 21:46.

Description

Fix an issue with URIs missing trailing slashes, like "/maniphest"

Summary:
In D3144, I made us look in application maps to find routing rules. However, we don't process all the maps when we 404 and try to do a "/" redirect. Process all of the maps.

Additionally, in D3146 I made the menu items application-driven. However, some pages (like 404) don't have a controller. Drop the requirement that the controller be nonnull.

Test Plan:

  • Visited "/maniphest", got a redirect after this patch.
  • Visited "/asldknfalksfn", got a 404 after this patch.

Reviewers: davidreuss, vrana, btrahan

Reviewed By: davidreuss

CC: aran

Maniphest Tasks: T1607

Differential Revision: https://secure.phabricator.com/D3158

Details

Committed
epriestley <git@epriestley.com>Aug 6 2012, 21:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbcb9de4ea1a3: Add a context field to symbol objects
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHebb7807bb41e: Fix an issue with URIs missing trailing slashes, like "/maniphest" (authored by epriestley <git@epriestley.com>).Aug 6 2012, 21:46