Homec4science

Add getStrList() to AphrontRequest

Authored by epriestley <git@epriestley.com> on Jan 4 2012, 06:57.

Description

Add getStrList() to AphrontRequest

Summary:

  • We have a few places where we do some kind of ad-hoc comma list tokenizing,

and I'm adding another one in D1290. Add a helper to the request object.

  • Add some unit tests.

Test Plan:

  • Ran unit tests.
  • Used PHID manager, Maniphest custom view, and Repository project editor.

Reviewers: btrahan, fratrik, jungejason

Reviewed By: btrahan

CC: aran, btrahan, epriestley

Differential Revision: https://secure.phabricator.com/D1302

Details

Committed
epriestley <git@epriestley.com>Jan 4 2012, 19:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7831b9242760: Improve LiskDAO::__call() performance
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHec1df21befae: Add getStrList() to AphrontRequest (authored by epriestley <git@epriestley.com>).Jan 4 2012, 19:18