Homec4science

Improve behavior of inline comment dialog

Authored by epriestley <git@epriestley.com> on Mar 5 2013, 21:30.

Description

Improve behavior of inline comment dialog

Summary:
Fixes T2669.

  • Currently, making an inline comment does not focus the textarea. Instead, focus the textarea.
  • Currently, the positioning is kind of buggy. Make it viewport-relative and put the dialog slightly below the inline reticle.
  • Use JX.Workflow more and simplify some of the ajax stuff.

Test Plan: Created inline comments.

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T2669

Differential Revision: https://secure.phabricator.com/D5229

Details

Committed
epriestley <git@epriestley.com>Mar 5 2013, 21:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbd4ce3580ccf: Fix inline highlight behaviors for Pholio
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHec6f566bc187: Improve behavior of inline comment dialog (authored by epriestley <git@epriestley.com>).Mar 5 2013, 21:30