Homec4science

Audit / Herald - make audits added via herald "required"

Authored by Bob Trahan <btrahan@phacility.com> on Oct 21 2014, 01:46.

Description

Audit / Herald - make audits added via herald "required"

Summary: as opposed to "requested". Also re-jigger how the "reason" works so the herald editor can get more specific data rather than a generic message. Fixes T6345 along with companion diff D10726.

Test Plan: made a herald rule to add auditors to a commit and saw it work!

Reviewers: epriestley, chad

Reviewed By: chad

Subscribers: Korvin, epriestley

Maniphest Tasks: T6345

Differential Revision: https://secure.phabricator.com/D10730

Details

Committed
Bob Trahan <btrahan@phacility.com>Oct 21 2014, 01:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPHeaf6ca3b6433: Normalize AuditStatusConstant Colors
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHec82ad2d16ed: Audit / Herald - make audits added via herald "required" (authored by Bob Trahan <btrahan@phacility.com>).Oct 21 2014, 01:46