Homec4science

Only table of contents are shown for large diffs by default.

Authored by tuomaspelkonen <tuomas.pelkonen@fb.com> on Apr 15 2011, 23:25.

Description

Only table of contents are shown for large diffs by default.

Summary:
Differential used to only show diffs for the first 100 files. Now all
the files are shown in the table of contents and there is a link to
the standalone view for every file. The inline diffs can still be
seen, if user clicks "Show All Files Inline".

Inline comments can also be added in the standalone view, but there is
no form to submit them. The revision page must be reloaded to able to
submit the inline comment.

Test Plan:
Changed the limit to three for testing purposes and checked that a diff of
mine with 5 files had the links to the standalone views. Made sure that
adding a comment in a standalone view worked and that after reloading the
revision page the comment was visible. Changed the limit back to 100 and
made sure that my diff had all the files inline and that the anchor links
were working.

Reviewed By: jungejason
Reviewers: jungejason
CC: epriestley, simpkins, jungejason, tuomaspelkonen
Differential Revision: 147

Details

Committed
tuomaspelkonen <tuomas.pelkonen@fb.com>Apr 19 2011, 01:26
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc223aaa79e72: Enable phd to load extra libraries
Branches
Unknown
Tags
Unknown

Event Timeline

tuomaspelkonen <tuomas.pelkonen@fb.com> committed rPHecc32e4d08c4: Only table of contents are shown for large diffs by default. (authored by tuomaspelkonen <tuomas.pelkonen@fb.com>).Apr 19 2011, 01:26