Homec4science

Allow users to create buildables from diffs

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on Nov 10 2013, 00:08.

Description

Allow users to create buildables from diffs

Summary:
Now that diffs have PHIDs we can create buildables for them.

This also adds buildable.diff in the variables list so the diff ID is available, and it also fixes the Cancel button on "Edit Plan" page so it redirects to the right place.

Test Plan: Created a buildable from a diff, ran a build plan against it that had echo ${buildable.diff} and got the right ID. Also tested the "Edit Plan" cancel redirect.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D7546

Details

Committed
epriestley <git@epriestley.com>Nov 10 2013, 00:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPH79ef667dfdc8: Render build status on revisions and commits
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHeccbbce9a282: Allow users to create buildables from diffs (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).Nov 10 2013, 00:08