Homec4science

Prevent "Spaces" field from being set to inconsistent values

Authored by epriestley <git@epriestley.com> on Dec 17 2015, 20:00.

Description

Prevent "Spaces" field from being set to inconsistent values

Summary:
At least for now, the "Space" field is just a subfield of the "Visible To" field, so:

  • it doesn't get any separate settings; and
  • it always uses the "Visible To" settings.

Test Plan:

  • Created a form with a hidden view policy field.
  • Created stuff with no "you must pick a space" errors.
  • Created stuff with a normal form.
  • Prefilled "Space" on a noraml form.
  • Verified that trying to prefill "Space" on a form with "Visible To" hidden does nothing.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14812

Details

Committed
epriestley <git@epriestley.com>Dec 17 2015, 20:22
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbd7981c750ae: Improve the clarity of transactions that affect policies and spaces during…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHed43b31cb122: Prevent "Spaces" field from being set to inconsistent values (authored by epriestley <git@epriestley.com>).Dec 17 2015, 20:22